Gentoo Archives: gentoo-portage-dev

From: Alexandru Elisei <alexandru.elisei@×××××.com>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] sync.py: add warning when sync-type is not set
Date: Tue, 31 Jan 2017 19:33:22
Message-Id: CAB-4s4nE=t7ackTmzmHG28=KnqCGkk6WcirJs2=YVcvN4OQ00w@mail.gmail.com
1 ---
2 pym/portage/emaint/modules/sync/sync.py | 12 +++++++++---
3 1 file changed, 9 insertions(+), 3 deletions(-)
4
5 diff --git a/pym/portage/emaint/modules/sync/sync.py
6 b/pym/portage/emaint/modules/sync/sync.py
7 index 076297a..b4d65e7 100644
8 --- a/pym/portage/emaint/modules/sync/sync.py
9 +++ b/pym/portage/emaint/modules/sync/sync.py
10 @@ -205,9 +205,15 @@ class SyncRepos(object):
11 k = "--" + k.replace("_", "-")
12 self.emerge_config.opts[k] = v
13
14 - selected_repos = [repo for repo in selected_repos if repo.sync_type
15 is not None]
16 msgs = []
17 - if not selected_repos:
18 + valid_repos = []
19 + for repo in selected_repos:
20 + if repo.sync_type is None:
21 + msgs.extend([warn(" * ") + "Missing sync-type for repo: " + \
22 + repo.name + ", skipping...\n"])
23 + else:
24 + valid_repos.append(repo)
25 + if not valid_repos:
26 msgs.append("Emaint sync, nothing to sync... returning")
27 if return_messages:
28 msgs.extend(self.rmessage([('None', os.EX_OK)], 'sync'))
29 @@ -223,7 +229,7 @@ class SyncRepos(object):
30 if 'parallel-fetch' in self.emerge_config.
31 target_config.settings.features else 1)
32 sync_scheduler = SyncScheduler(emerge_config=self.emerge_config,
33 - selected_repos=selected_repos, sync_manager=sync_manager,
34 + selected_repos=valid_repos, sync_manager=sync_manager,
35 max_jobs=max_jobs,
36 event_loop=global_event_loop() if portage._internal_caller else
37 EventLoop(main=False))
38 --
39 2.10.2