Gentoo Archives: gentoo-portage-dev

From: Jason Stubbs <jstubbs@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [5/7] portage_exec cleanups
Date: Sat, 29 Oct 2005 10:56:21
Message-Id: 200510291956.47607.jstubbs@gentoo.org
In Reply to: [gentoo-portage-dev] [0/7] portage_exec cleanups (WAS: [Bug 104705] emerge doesn't print complete error message) by Jason Stubbs
1 All file descriptors opened by spawn() are now closed in the correct places.
2 The code that closes all unnecessary descriptors via brute force is no longer
3 required.
4
5 I found that a file descriptor was being left open and passed around. However,
6 it was definately not created in spawn(). It seems to me though that code
7 outside of spawn should take care of closing (or telling spawn to close) any
8 unnecessary FDs.

Attachments

File name MIME type
05-remove-bulk-fd-closing.patch text/x-diff

Replies

Subject Author
Re: [gentoo-portage-dev] [5/7] portage_exec cleanups Jason Stubbs <jstubbs@g.o>