Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH v2] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses
Date: Tue, 21 Mar 2017 02:22:31
Message-Id: c5fb8d6a-fcdc-5bf5-d378-6f2f5ff60e8c@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v2] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses by "Michał Górny"
1 On 03/18/2017 10:26 AM, Michał Górny wrote:
2 > @@ -129,6 +130,9 @@ class EbuildPhase(CompositeTask):
3 > # If the environment.bz2 doesn't exist, then ebuild.sh will
4 > # source the ebuild as a fallback.
5 >
6 > + if self.phase == "unpack":
7 > + _prepare_fake_filesdir(self.settings)
8 > +
9 > self._start_lock()
10
11 The _prepare_fake_filesdir call should not execute until the build
12 directory lock has been acquired (initiated by the _start_lock call).
13
14 The beginning of the _start_ebuild method is a good place.
15 --
16 Thanks,
17 Zac