Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH] emerge: disable --changed-deps-report by default (bug 645780)
Date: Sat, 03 Feb 2018 02:53:17
Message-Id: 20180203025235.6141-1-zmedico@gentoo.org
1 This option is too noisy to enable by default, since it reports
2 hundreds of packages for most users.
3
4 Suggested-by: Michał Górny <mgorny@g.o>
5 Bug: https://bugs.gentoo.org/645780
6 ---
7 man/emerge.1 | 7 +------
8 pym/_emerge/create_depgraph_params.py | 6 ++----
9 2 files changed, 3 insertions(+), 10 deletions(-)
10
11 diff --git a/man/emerge.1 b/man/emerge.1
12 index 189e6f879..810336fa4 100644
13 --- a/man/emerge.1
14 +++ b/man/emerge.1
15 @@ -469,12 +469,7 @@ respect to changed build\-time dependencies is controlled by the
16 Tells emerge to report ebuilds for which the ebuild dependencies have
17 changed since the installed instance was built. Behavior with respect to
18 changed build\-time dependencies is controlled by the
19 -\fB\-\-with\-bdeps\fR option. If the \fB\-\-update\fR and \fB\-\-deep\fR
20 -options are enabled then this option is enabled automatically for a
21 -dependency calculation if the cost of report generation is relatively
22 -insignificant (any calculation exclusively involving binary packages is
23 -exempt). The \fIEMERGE_DEFAULT_OPTS\fR variable may be used to disable
24 -this by default.
25 +\fB\-\-with\-bdeps\fR option.
26 .TP
27 .BR \-\-changed\-use ", " \-U
28 Tells emerge to include installed packages where USE flags have
29 diff --git a/pym/_emerge/create_depgraph_params.py b/pym/_emerge/create_depgraph_params.py
30 index ecd65335c..6964bc65b 100644
31 --- a/pym/_emerge/create_depgraph_params.py
32 +++ b/pym/_emerge/create_depgraph_params.py
33 @@ -127,10 +127,8 @@ def create_depgraph_params(myopts, myaction):
34 if changed_deps is not None:
35 myparams['changed_deps'] = changed_deps
36
37 - changed_deps_report = myopts.get('--changed-deps-report')
38 - if (changed_deps_report != 'n' and
39 - not (myaction == 'remove' or '--usepkgonly' in myopts) and
40 - deep is True and '--update' in myopts):
41 + changed_deps_report = myopts.get('--changed-deps-report', 'n') == 'y'
42 + if changed_deps_report:
43 myparams['changed_deps_report'] = True
44
45 if myopts.get("--selective") == "n":
46 --
47 2.13.6

Replies