| 1 |
On Thu, 23 Apr 2015 10:38:24 -0700 |
| 2 |
Zac Medico <zmedico@g.o> wrote: |
| 3 |
|
| 4 |
> On 04/23/2015 09:01 AM, Brian Dolbec wrote: |
| 5 |
> > This bug caused great difficulty in determining the cause of the |
| 6 |
> > error message. This adds identifying code which states where the |
| 7 |
> > error message is coming from. It also adds the actual source which |
| 8 |
> > caused the error message in the first place. X-Gentoo-Bug: 542796 |
| 9 |
> > X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=542796 |
| 10 |
> > X-Gentoo-forum-thread: |
| 11 |
> > https://forums.gentoo.org/viewtopic-t-1014842.html |
| 12 |
> |
| 13 |
> Since varexpand already has an error_leader argument, we could use |
| 14 |
> that to report the source. The relevant varexpand calls are in |
| 15 |
> pym/portage/util/_dyn_libs/LinkageMapELF.py, added in commit |
| 16 |
> f1c1b8a77eebf7713b32e5f9945690f60f4f46de. |
| 17 |
|
| 18 |
|
| 19 |
Yes, that is a good idea. Should we do similar for all varexpand calls? |
| 20 |
|
| 21 |
Also, That is in addition to identifying that the message is being |
| 22 |
generated in portage.util varexpand()? So we don't keep looking for |
| 23 |
the problem/source in the wrong place like we just did? |
| 24 |
-- |
| 25 |
Brian Dolbec <dolsen> |
Archives