Archives
Archives
| From: | "Robin H. Johnson" <robbat2@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope | ||
| Date: | Fri, 08 Sep 2017 23:58:38 | ||
| Message-Id: | robbat2-20170908T235245-568923391Z@orbis-terrarum.net | ||
| In Reply to: | [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope by "Michał Górny" |
||
| 1 | On Thu, Aug 31, 2017 at 10:45:42PM +0200, Michał Górny wrote: |
| 2 | > + export PATH=/dev/null |
| 3 | Minor nitpick: The Single UNIX spec says that PATH is a set of prefixes, |
| 4 | and that they're treated as directories. |
| 5 | http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html |
| 6 | |
| 7 | I think it might be good to use either a non-existing path, or a known |
| 8 | empty directory (/var/empty), rather than /dev/null which DOES exist. |
| 9 | |
| 10 | -- |
| 11 | Robin Hugh Johnson |
| 12 | Gentoo Linux: Dev, Infra Lead, Foundation Asst. Treasurer |
| 13 | E-Mail : robbat2@g.o |
| 14 | GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |
| 15 | GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope | Ulrich Mueller <ulm@g.o> |