Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)
Date: Sun, 28 May 2017 10:11:08
Message-Id: 20170528100750.14081-1-zmedico@gentoo.org
1 With FEATURES=binpkg-multi-instance, it is normal to have some
2 unused binary packages, so don't warn if the selected package
3 is the latest version and the most recent build.
4
5 X-Gentoo-bug: 619620
6 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=619620
7 ---
8 pym/_emerge/depgraph.py | 9 +++++++++
9 1 file changed, 9 insertions(+)
10
11 diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
12 index 726835dd4..2dc432431 100644
13 --- a/pym/_emerge/depgraph.py
14 +++ b/pym/_emerge/depgraph.py
15 @@ -876,6 +876,15 @@ class depgraph(object):
16 self._dynamic_config.ignored_binaries.pop(pkg)
17 break
18
19 + # NOTE: The Package.__ge__ implementation accounts for
20 + # differences in build_time, so the warning about "ignored"
21 + # packages will be triggered if both packages are the same
22 + # version and selected_pkg is not the most recent build.
23 + if (selected_pkg.type_name == "binary" and
24 + selected_pkg >= pkg):
25 + self._dynamic_config.ignored_binaries.pop(pkg)
26 + break
27 +
28 if selected_pkg.installed and \
29 selected_pkg.cpv == pkg.cpv and \
30 selected_pkg.build_time == pkg.build_time:
31 --
32 2.13.0

Replies