Re: [gentoo-portage-dev] [PATCH v2] Support disabling docompress for binary package builds

[Zac Medico]

On 11/04/2018 01:20 AM, Michał Górny wrote:
> Add FEATURES=binpkg-docompress that can be used whether docompress
> compression is performed before or after creating binary packages.  With
> the feature enabled (the default), the current behavior of storing
> compressed files in binpkg is preserved.  With it disabled, uncompressed
> files are stored inside binary package and are compressed when
> installing.
>
> Storing uncompressed files in binary packages has two advantages:
>
> 1. Avoids the double-compression penalty, effectively improving binary
>    package compression speed and compression ratio.
>
> 2. Allows the same packages to be reused on systems with different
>    docompress configurations.
>
> The option is roughly backwards compatible.  Old Portage versions will
> install packages created with FEATURES=-binpkg-docompress correctly,
> albeit without compression.  Portage with FEATURES=binpkg-docompress
> should install old binpackages semi-correctly, potentially recompressing
> them (and throwing already-compressed warnings on format mismatch).
> The new behavior is left off by default to avoid those problems.
>
> Signed-off-by: Michał Górny <mgorny@g.o>
> ---
>  bin/misc-functions.sh                  | 43 +++++++++++++++++++++++---
>  bin/phase-functions.sh                 |  2 +-
>  cnf/make.globals                       |  2 +-
>  lib/portage/const.py                   |  1 +
>  lib/portage/dbapi/vartree.py           | 12 +++++++
>  lib/portage/package/ebuild/doebuild.py |  4 ++-
>  man/ebuild.1                           |  5 +++
>  man/make.conf.5                        |  6 ++++
>  8 files changed, 68 insertions(+), 7 deletions(-)
>
> Changes in v2:
> * added .instprepped file logic,
> * added instprep -> install dependency,
> * documented in ebuild.1.
>
> I've tested this thoroughly via ebuild(1) and emerge(1).

Looks good, thanks, please merge.
-- 
Thanks,
Zac