Re: [gentoo-portage-dev] [PATCH] [checksum] Do not use secure memory for pygcrypt backend

[Zac Medico]

On 12/05/2017 12:00 PM, Michał Górny wrote:
> Disable using secure memory for pygcrypt backend since we are not
> processing secrets. This can avoid the libgcrypt memory error; however,
> it turned out to be a huge memory/resource leak which needs to be fixed
> independently.
> ---
>  pym/portage/checksum.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py
> index 9e7bffea9..4174638e6 100644
> --- a/pym/portage/checksum.py
> +++ b/pym/portage/checksum.py
> @@ -161,7 +161,8 @@ if False:
>
>  		class GCryptHashWrapper(object):
>  			def __init__(self, algo):
> -				self._obj = pygcrypt.hashcontext.HashContext(algo=algo)
> +				self._obj = pygcrypt.hashcontext.HashContext(algo=algo,
> +						secure=False)
>
>  			def update(self, data):
>  				self._obj.write(data)
>

Looks good, please merge.
-- 
Thanks,
Zac