Gentoo Archives: gentoo-portage-dev

From: Alec Warner <antarus@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Wolfgang E. Sanyer" <WolfgangESanyer@×××××.com>, Matt Turner <mattst88@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 1/4] portage.dep.Atom: Clean up __new__ parameters
Date: Wed, 09 Mar 2022 01:12:08
Message-Id: CAAr7Pr8ykBCTo7AvOmkQ5AbE1qDwVB04ZPndQxk8-BJ1OQ+LMw@mail.gmail.com
In Reply to: [gentoo-portage-dev] [PATCH 1/4] portage.dep.Atom: Clean up __new__ parameters by Matt Turner
1 maybe *unused_args, **unused_kwargs, unsure on the style guide for
2 that (normally its _)
3
4 But feel free to merge as-is.
5
6 -A
7
8 On Wed, Feb 23, 2022 at 8:15 PM Matt Turner <mattst88@g.o> wrote:
9 >
10 > From: "Wolfgang E. Sanyer" <WolfgangESanyer@×××××.com>
11 >
12 > Reviewed-by: Matt Turner <mattst88@g.o>
13 > Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@×××××.com>
14 > ---
15 > lib/portage/dep/__init__.py | 12 +-----------
16 > 1 file changed, 1 insertion(+), 11 deletions(-)
17 >
18 > diff --git a/lib/portage/dep/__init__.py b/lib/portage/dep/__init__.py
19 > index 3b3577025..13c0f4ef7 100644
20 > --- a/lib/portage/dep/__init__.py
21 > +++ b/lib/portage/dep/__init__.py
22 > @@ -1489,17 +1489,7 @@ class Atom(str):
23 > def __init__(self, forbid_overlap=False):
24 > self.overlap = self._overlap(forbid=forbid_overlap)
25 >
26 > - def __new__(
27 > - cls,
28 > - s,
29 > - unevaluated_atom=None,
30 > - allow_wildcard=False,
31 > - allow_repo=None,
32 > - _use=None,
33 > - eapi=None,
34 > - is_valid_flag=None,
35 > - allow_build_id=None,
36 > - ):
37 > + def __new__(cls, s, *args, **kwargs):
38 > return str.__new__(cls, s)
39 >
40 > def __init__(
41 > --
42 > 2.34.1
43 >
44 >