Re: [gentoo-portage-dev] use* cleanup

[Mike Frysinger]

On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote:
> I hope this is just an artifact of the patch being a bit opaque. The
> inconsistent indentation in the patch is a consequence of emacs bash mode
> using a different indentation style than (I guess) vi(m). I'm sure even in
> vi you can re-indent my code with one simple key-chord.

no idea, i dont use vi ... but you're writing the patch which means you get to 
fix it ;)

> The immediate motivation of my examining this code was a request on
> #gentoo-dev-help by lack for something which I could with my new code
> easily write like this:
>
> use_mime() {
>     local WORD="$(_if $2 $2 $1)"
>
>     _use $1 "${WORD};"
> }

write where ?  in eclasses/ebuilds ?

>     local SUFFIX="$(_if $3 "=$3")"
>     local WORD="$(_if $2 $2 $1)"

local FOO=$(...)
extraneous quoting makes eyes bleed

> _if() {
>     if $1; then echo $2; else echo $3; fi
> }

$1 && echo $2 || echo $3

>     if hasq ${flag} ${USE} ; then
> 	echo ${string_success}; return ${found}
>     else
> 	echo ${string_failure}; return $((!found))
>     fi

no point in cuddling those lines

> What's not to like?

when you've written it out, it does look much nicer ... but i'd like to 
understand the motivation behind it first ...
-mike