Gentoo Archives: gentoo-portage-dev

From: Wynn Wolf Arbor <wolf@××××××.systems>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH 0/2] Use consistent list of booleans & validate verify-commit-signature
Date: Thu, 02 Jul 2020 15:50:58
Message-Id: 20200702155018.82993-1-wolf@oriole.systems
1 Hi,
2
3 Whilst configuring a bunch of overlay repositories via repos.conf, I
4 discovered that not all boolean options take the same values. Some only
5 take 'true' and 'false', others are documented only as 'yes' or 'no',
6 but take 'true', 'false', 'yes', and 'no'. This is inconsistent and can
7 lead to very confusing outcomes, so I decided to write a patch.
8
9 I came across https://bugs.gentoo.org/703698 whilst working on this, and
10 since my work was tangentially related, decided to fix that as well.
11
12 Wynn Wolf Arbor (2):
13 repos.conf: Use consistent list of values for boolean options
14 git: Verify boolean values passed to sync-git-verify-commit-signature
15
16 lib/portage/repository/config.py | 4 +--
17 lib/portage/sync/modules/git/__init__.py | 11 ++++++++
18 lib/portage/sync/modules/git/git.py | 2 +-
19 lib/portage/sync/modules/rsync/rsync.py | 2 +-
20 man/portage.5 | 45 +++++++++++++++-----------------
21 5 files changed, 36 insertions(+), 28 deletions(-)

Replies