| 1 |
On Sat, 17 Jan 2015 14:16:43 +0100 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> Fix module_names enumeration to consider all modules. Before, the |
| 5 |
> first module on the list was omitted ('cvs' in this case). |
| 6 |
> |
| 7 |
> Another thing is, the CVS module is completely, utterly and inevitably |
| 8 |
> broken. And the whole syncing thing is a great pile of terribly |
| 9 |
> mis-designed, unnecessarily complex code which can't work unless it is |
| 10 |
> worked around like git module does... |
| 11 |
> --- |
| 12 |
|
| 13 |
|
| 14 |
Really??? this just shows how immature you really are. This type of |
| 15 |
commit message does not belong in __ANY__ repo, therefore this is |
| 16 |
rejected. |
| 17 |
|
| 18 |
|
| 19 |
> pym/portage/sync/controller.py | 2 +- |
| 20 |
> 1 file changed, 1 insertion(+), 1 deletion(-) |
| 21 |
> |
| 22 |
> diff --git a/pym/portage/sync/controller.py |
| 23 |
> b/pym/portage/sync/controller.py index 9001298..3d217db 100644 |
| 24 |
> --- a/pym/portage/sync/controller.py |
| 25 |
> +++ b/pym/portage/sync/controller.py |
| 26 |
> @@ -119,7 +119,7 @@ class SyncManager(object): |
| 27 |
> self.callback = callback or self._sync_callback |
| 28 |
> self.repo = repo |
| 29 |
> self.exitcode = 1 |
| 30 |
> - if repo.sync_type in self.module_names[1:]: |
| 31 |
> + if repo.sync_type in self.module_names: |
| 32 |
> tasks = |
| 33 |
> [self.module_controller.get_class(repo.sync_type)] else: |
| 34 |
> msg = "\n%s: Sync module '%s' is not an |
| 35 |
> installed/known type'\n" \ |
| 36 |
|
| 37 |
thanks for the one line patch. It was something I missed removing when |
| 38 |
I first ported the controller module from the emaint one which |
| 39 |
pre-pends an 'all' to the list. |
| 40 |
|
| 41 |
-- |
| 42 |
Brian Dolbec <dolsen> |
Archives