| 1 |
On 26 May 2015 08:58, Zac Medico wrote: |
| 2 |
> On 05/26/2015 07:24 AM, Mike Frysinger wrote: |
| 3 |
> > + # Only check on 32-bit systems. Filtering by $ARCH here isn't perfect, but |
| 4 |
> > + # it should be good enough for our needs. |
| 5 |
> > + case ${ARCH} in |
| 6 |
> > + arm|mips|ppc|sh|x86) ;; |
| 7 |
> > + *) return ;; |
| 8 |
> > + esac |
| 9 |
> |
| 10 |
> Shouldn't we also enable this for 64-bit archs when multilib is enabled? |
| 11 |
|
| 12 |
yes, but i think we should start here first. getting multilib right is kind of |
| 13 |
a pain. this should give us enough coverage i think to get people to start |
| 14 |
filing bugs which implicitly covers multilib users. once the dust has settled, |
| 15 |
we can look at expanding the multilib coverage. although that would really |
| 16 |
require a python implementation, and the current install hooks logic implicitly |
| 17 |
requires every file to be bash. |
| 18 |
|
| 19 |
to use your pkg-config example, it installs 32bit & 64bit ELFs into /usr/bin. |
| 20 |
we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs like |
| 21 |
x32 & n32. |
| 22 |
|
| 23 |
ideally we'd scan the whole multilib dir, but that too runs into problems. |
| 24 |
when /usr/lib is the path for both x86 multilib and non-multilib content (like |
| 25 |
libexec stuff), we can't blindly scan & reject all ELFs in there. the previous |
| 26 |
note about ILP32 applies here too. |
| 27 |
|
| 28 |
so if we're happy with this implementation, i'll start a thread on gentoo-dev so |
| 29 |
people aren't caught by surprise, and we can merge this for the next release. |
| 30 |
-mike |
Archives