Gentoo Archives: gentoo-portage-dev

From: Brian Harring <ferringb@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] r2522 commit
Date: Thu, 05 Jan 2006 05:36:10
Message-Id: 20060105053520.GB14338@nightcrawler.e-centre.net
In Reply to: [gentoo-portage-dev] r2522 commit by Alec Warner
1 On Wed, Jan 04, 2006 at 09:33:07PM -0500, Alec Warner wrote:
2 > Author: ferringb
3 > Date: 2006-01-04 08:57:07 +0000 (Wed, 04 Jan 2006)
4 > New Revision: 2522
5 >
6 > Modified:
7 > main/trunk/pym/portage_dep.py
8 > Log:
9 > el buggo pointed out via spyderous.
10 > || ( a ( x? ( b ) y? ( c ) ) )
11 > -x -y , was resulting in || ( a () )
12 >
13 > the main consumer of this, portage.dep_check is stupid, and was assuming
14 > () was valid.
15 > It's not, obviously.
16 >
17 > Long term bug, around in at least .51 . Should correct dep_check
18 > handling of it also, but no reason to be
19 > handing () in the result lists also.
20 >
21 > Sadly this breaks something else we apparently need and use ( or at
22 > least Ciaran tells me so :) )
23 >
24 > DEPEND="|| ( )" which should evaluate to DEPEND="" doesn't with this
25 > patch. It dies, which is bad, because while stupid, it should work.
26
27 Corrected with a nasty recursive filter tagged into dep_check.
28
29 I really hate that code on a side note.
30
31 ~harring