Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] TaskSequence.py: Fix starting an empty queue (bug 506186)
Date: Fri, 04 Apr 2014 20:14:00
Message-Id: 533F127B.6020405@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 2/2] TaskSequence.py: Fix starting an empty queue (bug 506186) by Brian Dolbec
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 04/04/14 21:36, Brian Dolbec wrote:
5 > --- pym/_emerge/TaskSequence.py | 5 +++-- 1 file changed, 3
6 > insertions(+), 2 deletions(-)
7 >
8 > diff --git a/pym/_emerge/TaskSequence.py
9 > b/pym/_emerge/TaskSequence.py index 1fecf63..b4bfefe 100644 ---
10 > a/pym/_emerge/TaskSequence.py +++ b/pym/_emerge/TaskSequence.py @@
11 > -30,8 +30,9 @@ class TaskSequence(CompositeTask):
12 > CompositeTask._cancel(self)
13 >
14 > def _start_next_task(self): -
15 > self._start_task(self._task_queue.popleft(), -
16 > self._task_exit_handler) + if self._task_queue: +
17 > self._start_task(self._task_queue.popleft(), +
18 > self._task_exit_handler)
19 >
20 > def _task_exit_handler(self, task): if self._default_exit(task) !=
21 > os.EX_OK:
22 >
23 I assume the check doesn't have to be atomic, so LGTM. Too long commit
24 msg though. Should be something like "TaskSequence: Don't start empty
25 queue (bug 506186)".
26
27 - --
28 Alexander
29 bernalex@g.o
30 https://secure.plaimi.net/~alexander
31 -----BEGIN PGP SIGNATURE-----
32 Version: GnuPG v2.0.22 (GNU/Linux)
33 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
34
35 iF4EAREIAAYFAlM/EnsACgkQRtClrXBQc7WzCQD/W40mrQvUOlvnwXxZV3ZEOw5O
36 q02iC0nrH5shF8jpcwwA/0Yfgw5OLgyZYjrCpzWdxJZnZe2TbX0R8DtJIl9gCGTa
37 =fkZ3
38 -----END PGP SIGNATURE-----