| 1 |
> On Sun, Aug 28, 2005 at 02:46:28PM +0900, Jason Stubbs wrote: |
| 2 |
>> On Saturday 27 August 2005 19:53, Brian Harring wrote: |
| 3 |
>> > Please test this out; if you want to test the EAPI checking, tag |
| 4 |
>> > EAPI=1 into an ebuild, and try making emerge bail. |
| 5 |
>> |
| 6 |
>> + print "EAPI check, unknown source "+str(x[0])+" for "+x[2]+", this |
| 7 |
>> shouldn't occur",mylist |
| 8 |
>> + sys.exit(1) |
| 9 |
>> |
| 10 |
>> These two are in the patch. Can that be made an exception please? That |
| 11 |
>> way |
| 12 |
>> --debug could still be useful if the bug hits. |
| 13 |
> That's debugging; not knowing (due to design flaws) all potentials for |
| 14 |
> x[0], stuck that in debugging for anyone running the patch; people |
| 15 |
> hitting it reporting back (hopefully), for debugging |
| 16 |
> |
| 17 |
> Final version won't include it. |
| 18 |
> ~harring |
| 19 |
> |
| 20 |
|
| 21 |
pppfft, you were just complaining about all the sys.exit()'s in the code |
| 22 |
and then you go and add one yourself. raise something instead, even if |
| 23 |
it's just an Exception, that way it saves anyone from grepping through the |
| 24 |
code for the error message. |
| 25 |
|
| 26 |
-Alec |
| 27 |
|
| 28 |
PS: Squirrelmail sucks for actual work :P |
| 29 |
|
| 30 |
|
| 31 |
-- |
| 32 |
gentoo-portage-dev@g.o mailing list |
Archives