Gentoo Archives: gentoo-portage-dev

From: Brian Harring <ferringb@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] dep_opconvert in portage.py and portage_dep
Date: Mon, 19 Dec 2005 12:02:54
Message-Id: 20051219120125.GA27804@nightcrawler.e-centre.net
In Reply to: [gentoo-portage-dev] dep_opconvert in portage.py and portage_dep by Brian Harring
1 On Sun, Dec 18, 2005 at 04:50:37PM -0800, Brian Harring wrote:
2 > Yo.
3 >
4 > New one from the looks of it- someone who has time (say, person who
5 > commited it), please iron out the portage.dep_opconvert and
6 > portage_dep.dep_opconvert.
7 >
8 > Naming sucks at the very least, but they look to be a candidate for
9 > refactoring/elimination.
10
11 Addendum to this, bug 115983 is a direct result of this- the result is
12 || (a b) , masking of a isn't properly realized.
13
14 Might be overkill, but after yet another flip through that code,
15 I'm wondering why we haven't gutted that crap. Thoughts?
16
17 Yes, a refactoring will take a bit of time, and will probably
18 introduce a bug or two, but the code that's there *really* is pretty
19 damn groddy. :)
20
21 > ~harring