Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH 3/3] repoman: Enable testing dev profiles by default
Date: Sat, 03 Mar 2018 10:09:16
Message-Id: 20180303100851.28980-3-mgorny@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 1/3] repoman: Fix default for -e to 'n' (rather than inconsistent False) by "Michał Górny"
1 Enable testing 'dev' profiles by default. Those profiles are in the way
2 of becoming stable, and therefore it is crucial that developers test
3 that their changes do not break them. Instead of requiring developers
4 to explicitly type 'repoman full -d' all the time, just test them
5 by default.
6 ---
7 repoman/pym/repoman/argparser.py | 2 +-
8 repoman/pym/repoman/tests/simple/test_simple.py | 2 +-
9 2 files changed, 2 insertions(+), 2 deletions(-)
10
11 diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
12 index 2e8aee1b6..3359e2f65 100644
13 --- a/repoman/pym/repoman/argparser.py
14 +++ b/repoman/pym/repoman/argparser.py
15 @@ -162,7 +162,7 @@ def parse_args(argv, qahelp, repoman_default_opts):
16
17 parser.add_argument(
18 '-d', '--include-dev-profiles', choices=('y', 'n'), metavar='<y|n>',
19 - default='n',
20 + default='y',
21 help='include dev profiles in dependency checks')
22
23 parser.add_argument(
24 diff --git a/repoman/pym/repoman/tests/simple/test_simple.py b/repoman/pym/repoman/tests/simple/test_simple.py
25 index 494152eca..f254336d9 100644
26 --- a/repoman/pym/repoman/tests/simple/test_simple.py
27 +++ b/repoman/pym/repoman/tests/simple/test_simple.py
28 @@ -191,7 +191,7 @@ class SimpleRepomanTestCase(TestCase):
29 ("", git_cmd + ("init-db",)),
30 ("", git_cmd + ("add", ".")),
31 ("", git_cmd + ("commit", "-a", "-m", "add whole repo")),
32 - ("", repoman_cmd + ("full", "-d", "y")),
33 + ("", repoman_cmd + ("full",)),
34 ("", cp_cmd + (test_ebuild, test_ebuild[:-8] + "2.ebuild")),
35 ("", git_cmd + ("add", test_ebuild[:-8] + "2.ebuild")),
36 ("", repoman_cmd + ("commit", "-m", "cat/pkg: bump to version 2")),
37 --
38 2.16.2

Replies