Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: Michael 'veremitz' Everitt <gentoo@×××××××.xyz>, gentoo-portage-dev@l.g.o
Subject: Re: Fwd: [gentoo-portage-dev] [PATCH v2] Support PORTAGE_LOG_FILTER_FILE (bug 709746)
Date: Tue, 03 Mar 2020 06:58:26
Message-Id: 1e9115db-8025-1690-e516-cddf2a4ffdbf@gentoo.org
1 On 3/2/20 10:33 PM, Michael 'veremitz' Everitt wrote:
2 >> diff --git a/man/make.conf.5 b/man/make.conf.5
3 >> index f82fed65a..69bfa6cdf 100644
4 >> --- a/man/make.conf.5
5 >> +++ b/man/make.conf.5
6 >> @@ -979,6 +979,10 @@ with an integer pid. For example, a value of "ionice \-c 3 \-p \\${PID}"
7 >> will set idle io priority. For more information about ionice, see
8 >> \fBionice\fR(1). This variable is unset by default.
9 >> .TP
10 >> +.B PORTAGE_LOG_FILTER_FILE
11 >> +This variable specifies a command that filters build log output to a
12 >> +log file.
13 >> +.TP
14 >> .B PORTAGE_LOGDIR
15 >> This variable defines the directory in which per\-ebuild logs are kept.
16 >> Logs are created only when this is set. They are stored as
17 >
18 > I'm somewhat confused by the variable name "PORTAGE_LOG_FILTER_FILE" - the
19 > suffix of 'file' suggests it references a file rather than the command I
20 > believe we're intending - perhaps "PORTAGE_LOG_FILE_FILTER_CMD" may be more
21 > explicit?
22
23 Yes, I agree. Renamed:
24
25 https://gitweb.gentoo.org/proj/portage.git/commit/?id=e24859eaa03ec86e10d842296f5570dd98bed4b7
26
27
28 > Perhaps the feature name/bug also needs tweaking to reflect this.
29 >
30 > Otherwise, looks very promising!
31
32
33 --
34 Thanks,
35 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature