1 |
W dniu czw, 25.01.2018 o godzinie 22∶55 -0800, użytkownik Zac Medico |
2 |
napisał: |
3 |
> On 01/25/2018 10:42 PM, Michał Górny wrote: |
4 |
> > W dniu czw, 25.01.2018 o godzinie 21∶30 -0800, użytkownik Zac Medico |
5 |
> > napisał: |
6 |
> > > On 01/25/2018 01:11 AM, Michał Górny wrote: |
7 |
> > > > W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael |
8 |
> > > > Haubenwallner napisał: |
9 |
> > > > > Hi, |
10 |
> > > > > |
11 |
> > > > > ${Subject} ringing a bell here: |
12 |
> > > > > |
13 |
> > > > > dev-db/oracle-instantclient is fetch restricted. As a binary package with |
14 |
> > > > > multiple USE options there's a bunch of files to download - even for |
15 |
> > > > > multiple archs when multilib is active. |
16 |
> > > > > |
17 |
> > > > > So in pkg_nofetch() I'm telling the user whether a file to download is |
18 |
> > > > > "already here" or "still absent", by testing if $A exists in $DISTDIR. |
19 |
> > > > > |
20 |
> > > > > With ${Subject}, I'm wondering if DISTDIR is created for pkg_nofetch too. |
21 |
> > > > > |
22 |
> > > > |
23 |
> > > > You're doing the wrong thing then. DISTDIR is not allowed |
24 |
> > > > in pkg_nofetch(). |
25 |
> > > |
26 |
> > > It seems to be a common assumption that it's allowed, this command |
27 |
> > > currently shows 163 results in the gentoo repo: |
28 |
> > > |
29 |
> > > git grep -l pkg_nofetch | xargs grep 'e\(log\|info\).*DISTDIR' | wc -l |
30 |
> > > |
31 |
> > > We should double check with the PMS maintainers to see if they think |
32 |
> > > it's worthy of an exception. Otherwise, we need to announce the issue on |
33 |
> > > the gentoo-dev mailing list. |
34 |
> > |
35 |
> > PMS maintainers already verified that back during the first run of those |
36 |
> > patches. However, we believe the only reasonable way to get this out of |
37 |
> > pkg_nofetch() is to actually stop it from working, so people would stop |
38 |
> > using it. |
39 |
> |
40 |
> Okay, that works for me. The patches looks good. Please merge. |
41 |
|
42 |
Merged, thanks. |
43 |
|
44 |
-- |
45 |
Best regards, |
46 |
Michał Górny |