Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK
Date: Tue, 21 Apr 2015 00:37:20
Message-Id: 55359BBB.4080605@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK by Bertrand Jacquin
1 On 04/20/2015 05:31 PM, Bertrand Jacquin wrote:
2 > On 21/04/2015 00:39, Zac Medico wrote:
3 >> These are in the master branch now:
4 >>
5 >> https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911
6 >>
7 >> https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169
8 >>
9 >
10 > Thanks for that :)
11 >
12 >> I modified the test as follows in order to ensure that it still works
13 >> with shell globs:
14 >>
15 >> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo
16 >> "${root}"/${no_inst}) ]] ; then
17 >
18 > I do not really understand the use case here, do you have an example ?
19 >
20 > Cheers,
21 >
22
23 Well, I don't use INSTALL_MASK myself, so I don't have a real-world
24 use-case for you. However, it's clear that the code will expand shell
25 globs, so I preserved that behavior for compatibility.
26 --
27 Thanks,
28 Zac

Replies