Archives
Archives
| From: | Brian Dolbec <dolsen@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check | ||
| Date: | Sun, 18 Jan 2015 16:49:17 | ||
| Message-Id: | 20150118084856.0f74d613.dolsen@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check by "Michał Górny" |
||
| 1 | On Sun, 18 Jan 2015 11:34:24 +0100 |
| 2 | Michał Górny <mgorny@g.o> wrote: |
| 3 | |
| 4 | > The 'git rev-parse' could succeed if one of the parent directories |
| 5 | > contained a git repository, and it also had unwanted error output. |
| 6 | > Instead, just check whether the '.git' directory exists. |
| 7 | > --- |
| 8 | > pym/portage/sync/modules/git/git.py | 14 +------------- |
| 9 | > 1 file changed, 1 insertion(+), 13 deletions(-) |
| 10 | > |
| 11 | > |
| 12 | |
| 13 | Looks good. Thanks. |
| 14 | -- |
| 15 | Brian Dolbec <dolsen> |