Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 0/2] git: drop privileges for gc and merge (bug 669496)
Date: Sun, 25 Nov 2018 17:54:19
Message-Id: 20181125095405.58d57380@professor-x
In Reply to: [gentoo-portage-dev] [PATCH 0/2] git: drop privileges for gc and merge (bug 669496) by Zac Medico
1 On Fri, 23 Nov 2018 16:15:23 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > Use portage.process.spawn (with new cwd parameter) and
5 > self.spawn_kwargs to drop privileges for git gc and merge commands.
6 >
7 > Fixes: 3cd8cf93abb6 ("GitSync: abort checkout for signature problem
8 > (bug 660372)") Fixes: 903c4b1a6768 ("GitSync: support sync-depth (bug
9 > 552814)") Bug: https://bugs.gentoo.org/669496
10 > Signed-off-by: Zac Medico <zmedico@g.o>
11 >
12 > Zac Medico (2):
13 > portage.process.spawn: add cwd parameter
14 > git: drop privileges for gc and merge (bug 669496)
15 >
16 > lib/portage/process.py | 13 ++++++++++---
17 > lib/portage/sync/modules/git/git.py | 10 ++++++----
18 > lib/portage/tests/sync/test_sync_local.py | 22 ++++++++++++++++++++--
19 > 3 files changed, 36 insertions(+), 9 deletions(-)
20 >
21
22 This looks good to me :)

Replies