| 1 |
On Tuesday 03 December 2013 04:19:27 Alexander Berntsen wrote: |
| 2 |
> Using git send-email since vapier told me to. I haven't used this before, |
| 3 |
> so sorry if I have done something wrong. Please let me know. |
| 4 |
|
| 5 |
looks ok from `git send-email` pov, but random comments not meant for the |
| 6 |
commit message should be below the --- line ;) |
| 7 |
|
| 8 |
as for the patch, i'm of the opinion that make.conf is not for documenting |
| 9 |
random USE_EXPAND-ed variables. |
| 10 |
|
| 11 |
this sort of thing should go into the relevant eclass, python-r1.eclass in |
| 12 |
this case. then people would read about it via `man python-r1.eclass`. |
| 13 |
|
| 14 |
there is the matter of visibility ... we could add a generic pointer to the |
| 15 |
make.conf man page discussing that there are many more variables that might |
| 16 |
impact the build and to look at the man page for the eclasses. |
| 17 |
-mike |
Archives