1 |
On 07/23/2013 11:33 PM, Tomáš Čech wrote: |
2 |
> Accept --pkg-format option which will override settings of |
3 |
> PORTAGE_BINPKG_FORMAT. Currently takes only one choice of |
4 |
> 'tar' (original gentoo binary package) and 'rpm'. |
5 |
|
6 |
The patch looks good. However, for flexibility, I think we should |
7 |
support multiple formats simultaneously. The EbuildBuild class could use |
8 |
an instance of TaskSequence to execute multiple EbuildBinpkg instances |
9 |
sequentially. Example pseudocode: |
10 |
|
11 |
binpkg_tasks = TaskSequence() |
12 |
for pkg_fmt in settings.get("PORTAGE_BINPKG_FORMAT", "tar").split(): |
13 |
binpkg_tasks.add(EbuildBinpkg(pkg_fmt)) |
14 |
|
15 |
-- |
16 |
Thanks, |
17 |
Zac |