Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, gmt@×××××.us
Subject: Re: [gentoo-portage-dev] [PATCH v3]] versions: Drop non-PMS "cvs." prefix in ${PV}
Date: Tue, 28 Nov 2017 22:30:53
Message-Id: cd81c647-834a-f562-7ab6-74926e96c371@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v3]] versions: Drop non-PMS "cvs." prefix in ${PV} by gmt@malth.us
1 On 11/27/2017 03:01 PM, gmt@×××××.us wrote:
2 > From: "Gregory M. Turner" <gmt@×××××××.net>
3 >
4 > This feature was introduced 12 years ago in (the cvs commit
5 > corresponding to the git commit) 9f3a46665c. There are a lot
6 > of reasons not to keep it around:
7 >
8 > o PMS permits no such prefix in ${PV}
9 > o Apparently nobody uses it (perhaps nobody /ever/ used it)
10 > o It special-cases cvs, which nobody uses, either, in 2017
11 > o Almost* causes ambiguity between ${PN} and ${PV} in ${P} if
12 > some future EAPI tried to support both this and dots in
13 > package names simultaneously.
14 >
15 > Therefore, remove it from from the "_v" regular expression,
16 > renumber hard-coded group indexes and nuke corresponding tests.
17 >
18 > *PMS would technically avoid abiguity as §3.1.2 requires ${PV}
19 > to "win" any such conflict over contested bits in the middle of
20 > ${P}. However, clearly it's prefereable for this rule to be as
21 > redundant as possible.
22 >
23 > Note: this is my 3rd spin of this commitmsg; it's coming along
24 > nicely I think :P
25 >
26 > Signed-off-by: Gregory M. Turner <gmt@×××××××.net>
27
28 Thanks, merged:
29
30 https://gitweb.gentoo.org/proj/portage.git/commit/?id=77d8abd747a15f90d7a45c334efecaf47261501a
31
32 --
33 Thanks,
34 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature