Gentoo Archives: gentoo-portage-dev

From: Alec Warner <antarus@g.o>
To: gentoo-portage-dev@l.g.o
Cc: bernalex@g.o
Subject: Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.
Date: Sun, 30 Mar 2014 18:50:29
Message-Id: CAAr7Pr90e08GvektXF+tjLpQDNTvTNBut9j7RhMkd_b2P-WxBg@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes. by "Michał Górny"
1 On Sun, Mar 30, 2014 at 12:56 AM, Michał Górny <mgorny@g.o> wrote:
2
3 > Dnia 2014-03-30, o godz. 00:03:02
4 > Alexander Berntsen <bernalex@g.o> napisał(a):
5 >
6 > > -----BEGIN PGP SIGNED MESSAGE-----
7 > > Hash: SHA256
8 > >
9 > > Please use a max 50 char commit message headline, without the period.
10 > >
11 > > On 29/03/14 19:45, Michał Górny wrote:
12 > > > +import locale +import math
13 > > Why not explicitly import what you are going to use? (On the form of
14 > > "from foo import bar, baz".)
15 >
16 > I feel like one of the points in using Python is to explicitly name
17 > functions (and modules) which you use, rather than importing everything
18 > in a single namespace and having people scroll up and down to see where
19 > functions come from.
20 >
21 >
22 I agree with mgorny here. Tons of existing portage code violates this rule,
23 and it bugs me a lot. I hope that in the future we can move to imports
24 based on modules (and for things that are really long, explicit assignment,
25 perhaps to a local.)
26
27 -A
28
29
30 > --
31 > Best regards,
32 > Michał Górny
33 >