| 1 |
On 10/09/2011 11:53 AM, Mike Frysinger wrote: |
| 2 |
> I'm not an expert at python, so trying to make sure I'm doing anything |
| 3 |
> too stupid. I tried to keep existing portage style, but feel free to |
| 4 |
> point out whatever. |
| 5 |
> |
| 6 |
> I can also push these myself, so if people are OK with them, just let |
| 7 |
> me know ... you don't have to merge+push yourself. |
| 8 |
|
| 9 |
LGTM. My only suggestion is to use os.path.basename(sys.argv[0]) in the |
| 10 |
usage string, since it can look kind of ridiculous if a full path is |
| 11 |
displayed there. |
| 12 |
-- |
| 13 |
Thanks, |
| 14 |
Zac |
Archives