From: | Zac Medico <zmedico@g.o> | ||
---|---|---|---|
To: | gentoo-portage-dev@l.g.o | ||
Subject: | Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? | ||
Date: | Tue, 12 Apr 2011 01:15:17 | ||
Message-Id: | 4DA3A770.8000901@gentoo.org | ||
In Reply to: | Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? by Zac Medico |
1 | On 04/11/2011 04:32 PM, Zac Medico wrote: |
2 | > On 04/11/2011 10:14 AM, Zac Medico wrote: |
3 | >> On 04/11/2011 09:04 AM, James Cloos wrote: |
4 | >>> the recently added sci-math/minisat ebuild has this: |
5 | >>> |
6 | >>> dodoc "${DISTDIR}"/MiniSat.pdf || die |
7 | >>> |
8 | >>> which results in: |
9 | >>> |
10 | >>> sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422 |
11 | >>> |
12 | >>> Is that a portage issue or an issue with the ebuild? |
13 | >>> |
14 | >>> My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March. |
15 | >>> |
16 | >>> -JimC |
17 | >> |
18 | >> It's a side-effect from this fix which makes dodoc preserve symlinks |
19 | >> like doins does in EAPI 4: |
20 | >> |
21 | >> https://bugs.gentoo.org/show_bug.cgi?id=356461 |
22 | >> |
23 | >> I guess that we could make doins automatically dereference any symlinks |
24 | >> that refer to files absolute paths. For symlinks that refer to |
25 | >> directories by absolute paths, we could continue to preserve the symlink |
26 | >> as we do now. |
27 | > |
28 | > Here's the patch: |
29 | > |
30 | > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3 |
31 | |
32 | Now it's constrained to $PORTAGE_ACTUAL_DISTDIR/ so that we don't stray |
33 | from PMS: |
34 | |
35 | http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de9a536f470919651e83ece51923594e8605781b |
36 | -- |
37 | Thanks, |
38 | Zac |
Subject | Author |
---|---|
Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? | James Cloos <cloos@×××××××.com> |