Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: check for ebuilds not using slot operator against multi-slot packages.
Date: Mon, 04 Aug 2014 13:21:50
Message-Id: 20140804062049.7ff8d8f1.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] repoman: check for ebuilds not using slot operator against multi-slot packages. by "Michał Górny"
1 On Mon, 4 Aug 2014 11:11:25 +0200
2 Michał Górny <mgorny@g.o> wrote:
3
4 > The idea if that a particular dependency atom matches more than one
5 > slot of a package, you are supposed to either use := or :* operator
6 > (or a specific :slot dependency), whichever is appropriate.
7 >
8 > This will help catching mistakes (when packages become slotted) and
9 > make cross-slot behavior clear (it is undefined with no slot
10 > operator). I will estimate the amount of new warnings later.
11 > ---
12 > bin/repoman | 28 +++++++++++++++++++++++-----
13 > 1 file changed, 23 insertions(+), 5 deletions(-)
14 >
15 > diff --git a/bin/repoman b/bin/repoman
16 > index 71fc7f0..b169393 100755
17 > --- a/bin/repoman
18 > +++ b/bin/repoman
19 > @@ -78,7 +78,8 @@ from portage.output import ConsoleStyleFile,
20 > StyleWriter from portage.util import writemsg_level
21 > from portage.util._argparse import ArgumentParser
22 > from portage.package.ebuild.digestgen import digestgen
23 > -from portage.eapi import eapi_has_iuse_defaults, eapi_has_required_use
24 > +from portage.eapi import eapi_has_iuse_defaults, eapi_has_required_use, \
25 > + eapi_has_slot_operator
26 >
27
28 +from portage.eapi import (eapi_has_iuse_defaults, eapi_has_required_use,
29 + eapi_has_slot_operator)
30
31 Please use brackets for long imports instead of using line continuation backslashes
32 --
33 Brian Dolbec <dolsen>