Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/util/locale.py: add a C module to help check locale
Date: Mon, 30 May 2016 12:45:52
Message-Id: 20160530054450.0f548cd1.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/util/locale.py: add a C module to help check locale by Alexander Berntsen
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On Mon, 30 May 2016 11:08:03 +0200
5 Alexander Berntsen <bernalex@g.o> wrote:
6
7 > On 27/05/16 16:26, Anthony G. Basile wrote:
8 > > However, this gets bogged down in implementation details and fails
9 > > with musl.
10 > Is it possible to elucidate this a bit more in a paragraph? Right now
11 > it reads a bit like "but this fails because reasons -_o_-", but in the
12 > future it might be nice to know said reasons.
13 >
14 > Patch 1 and 2 look great. Patch 3 looks good to me, but obviously
15 > MichaƂ knows more about this so I'll let him be the judge.
16 > - --
17 > Alexander
18 > bernalex@g.o
19
20 I agree that all 3 look good, But I would say that the other changes
21 Michal proposed should be their own commit(s). This being the first,
22 the others each adding to it.
23
24 - --
25 Brian Dolbec <dolsen>
26
27 -----BEGIN PGP SIGNATURE-----
28 Version: GnuPG v2.1
29
30 iQJ8BAEBCgBmBQJXTDXCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
31 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
32 QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7YBWYP/2iFd7DsDKDwZJtTjUJfWAdJ
33 o4EqXmRtPOom0EIf5etfuiTRIKVAnALo9SeFJtp8nkBkRTcv5sa9IfB8ZKucslgW
34 VwlZCNBbXQIWm/d7zFYWSWw6rm0JM6Yq5hIrQ9R4eaKXZTZfNZUZla1u9LnGYmcs
35 VgNXd7EZ1R5zIxugWlLca5FhoEuNHiSrBQn5Vi9mfkngNAeqd5sl+dHBpfrFJlPs
36 2a7ia1YXXMe6ZVYWD0QW0Z2NcuZ16/7wkI7GH6qqglXkitP31g4tLlQZsVD9MU9k
37 VggQCcA2wdzyaEmLMBn+qE0Uu0yZ+uhIvFLkkbRVbb33WG9u/P5HC6Eio8m7YGb4
38 2qywJUiJkmdpOlcpfKdvjUpGa8TKF1UqjlsZWYVB65jmx3g4pCorwd2y3nOJktG3
39 Qodzm4/b3vaK+qLTmJWXqcQr2nvlj9vaibbrhX6RUhsHtlZJPrujiLv6g7m0wL+W
40 0rLhWL0J1+rmI+uUjzW62YmE3b6Yc7oAL7PEXLU+/R7vLSMA/Brfy5x/wMgwoMCW
41 MAq53aagDXKO2jWVtHiZ2Dj4AAcl5CmA4Gw5gtEezVnIQNTj/Lcui/p+li2q8N9O
42 RN0uG7xffmSqwbivJCwPUesxKBRDsQMRHk0R2L4VI5CQSrEq8d8vZRNUlf8EGisX
43 ODRF7zi9Uvu7WwjRCk1L
44 =9G6+
45 -----END PGP SIGNATURE-----