| 1 |
On Wed, 3 Sep 2014 17:35:40 -0700 |
| 2 |
|
| 3 |
Version 2 with all noted things fixed, also the tests pass, and rebased |
| 4 |
onto the current master as of the travis-ci tests fix commit. |
| 5 |
|
| 6 |
|
| 7 |
Brian Dolbec <dolsen@g.o> wrote: |
| 8 |
|
| 9 |
> |
| 10 |
> Most of you know about the plugin-sync branch of our portage.git repo. |
| 11 |
> I believe it is ready for review and merge into master to become the |
| 12 |
> new sync code for the future. |
| 13 |
> |
| 14 |
> Rather than follow this with 49 patch mails ... |
| 15 |
|
| 16 |
It is up to 56 commits now... |
| 17 |
|
| 18 |
> I produced a final git |
| 19 |
> diff of all the changes. I have cleaned up and squashed the original |
| 20 |
> commits to a point I do not want to squash further. This will keep |
| 21 |
> enough development history for important changes for future |
| 22 |
> troubleshooting if it is needed. Instead of inlining this diff like |
| 23 |
> most people prefer, I have attached it. It is 4.4K+ lines long. |
| 24 |
> Probably too long for many email clients. Plus opeing it in an editor |
| 25 |
> will allow the editors syntax highlighting to make code review easier. |
| 26 |
> |
| 27 |
> I have fully rebased the code on the current master (commit |
| 28 |
> 582cb806f88 QA patch) and pushed it to both our gentoo repo and our |
| 29 |
> github gentoo/portage repo. For those that wish to review it using |
| 30 |
> githubs interface. You have that option too. |
| 31 |
> |
| 32 |
> Thank you to all those that contributed to the code and testing. |
| 33 |
|
| 34 |
|
| 35 |
I have the github comparison link [1] if you want to look at the |
| 36 |
commits, but remember many are in progress changes and can not be |
| 37 |
considered, final code. Please review the diff to master for final |
| 38 |
concerns you may have with a files code for a commit. |
| 39 |
|
| 40 |
I would like to merge it into master soon, to get a little more testing |
| 41 |
in git before the next release. We will also need to prepare a news |
| 42 |
item for the repos.config changes to be made (fairly minor, but some |
| 43 |
good new options). |
| 44 |
|
| 45 |
The attached diff file is 4465 lines long. So, it should take only a |
| 46 |
few minutes to review ;) |
| 47 |
|
| 48 |
[1] https://github.com/gentoo/portage/compare/plugin-sync?expand=1 |
| 49 |
|
| 50 |
-- |
| 51 |
Brian Dolbec <dolsen> |
Archives