Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] qfile assumes category names contain a hyphen
Date: Mon, 16 Mar 2009 21:06:06
Message-Id: 200903161706.01012.vapier@gentoo.org
In Reply to: Re: [gentoo-portage-dev] qfile assumes category names contain a hyphen by Ned Ludd
1 On Monday 16 March 2009 14:35:15 Ned Ludd wrote:
2 > On Mon, 2009-03-16 at 18:34 +0200, Amit Dor-Shifer wrote:
3 > > Hi all.
4 > >
5 > > While working on my overlay, I stumbled on an issue where qfile refused
6 > > to acknowledge an installed file as being part of my package.
7 > >
8 > > Looking into q's implementation (portage-utils-0.1.29), I see:
9 > >
10 > > amit0 portage-utils-0.1.29 # grep -A 2 next_entry
11 > > ./libq/vdb_get_next_dir.c next_entry:
12 > > ret = readdir(dir);
13 > > if (ret == NULL) {
14 > > --
15 > > goto next_entry;
16 > > if (strchr(ret->d_name, '-') == NULL)
17 > > if ((strcmp(ret->d_name, "virtual")) != 0)
18 > > goto next_entry;
19 > >
20 > > I encountered this since I used a new category, which only contained a
21 > > single word. Adding a hyphen and a 2nd token solved my issue, and now
22 > > qfile knows the file's association.
23 > >
24 > > Is this assumption, that category should be "stringA-stringB" documented
25 > > somewhere?
26 >
27 > We made that assumption for portage-utils as they can be used on a
28 > device which has no $PORTDIR at all. So when there is no categories file
29 > that exists we fell back to the rules that have been working well for
30 > the past %d years.
31 >
32 > We changed that behavior however a while ago. I thought this was in the
33 > tree. But I guess not if you are hitting it.
34 >
35 > http://sources.gentoo.org/viewcvs.py/gentoo-projects/portage-utils/libq/vdb
36 >_get_next_dir.c?r1=1.2&r2=1.3
37
38 we should do a new release already
39 -mike

Replies