Re: [gentoo-portage-dev] [PATCH] conf: Enable to set rsync extra opts per repository

[Brian Dolbec]

On Mon, 6 Jul 2015 11:28:36 -0700
Brian Dolbec <dolsen@g.o> wrote:

 
> hmm, this is the cvs module's module_spec, I was thinking we might be
> able to add the module_specific_opts there after the validate_config
> definition, like so:
>
> module_spec = {
> 	'name': 'cvs',
> 	'description': doc,
> 	'provides':{
> 		'cvs-module': {
> 			'name': "cvs",
> 			'class': "CVSSync",
> 			'description': doc,
> 			'functions': ['sync', 'new', 'exists'],
> 			'func_desc': {
> 				'sync': 'Performs a cvs up on the
> repository', 'new': 'Creates the new repository at the specified
> location', 'exists': 'Returns a boolean of whether the specified dir
> ' + 'exists and is a valid CVS
> repository', },
> 			'validate_config': CheckCVSConfig,
>                         'module_specific_opts': None,
> 		}
> 	}
> }
>
>
> Also, the config validation code should probably be exteneded for any
> module specific options as well.
>
>  I'll look into whether that will work.
> I'll add your patch and see about moving things around.
>


OK, I think I got it, I haven't tested your extra-options field, but a
normal rsync operation worked for me.  I simplified the naming some,
the "sync_cvs_repo" name was old and oblsolete (replaced by the
universal "auto-sync" setting).  So for rsync it is simply
"extra-options".  Also since they are being stored in a dictionary,
there is no need to sub the - for _. 

I think this should work out well.  Now it should be easier to add
branch support to the git module.

Try it out, see what you think.  You can squash my commits back into
yours with just a small mention of my contribution.  No big deal for
me ;)

I thank you for your work on this.

I've attached the 2 patches of changes.  Please test and check it for
errors (there is bound to be some) I haven't tested it thoroughly yet.


-- 
Brian Dolbec <dolsen>