| 1 |
On 04/30/2016 09:42 AM, Brian Dolbec wrote: |
| 2 |
> From 6ead9b76de648747ae72ac572768ca1f464ff23e Mon Sep 17 00:00:00 2001 |
| 3 |
> From: Brian Dolbec <dolsen@g.o> |
| 4 |
> Date: Sat, 30 Apr 2016 08:55:41 -0700 |
| 5 |
> Subject: [PATCH] repoman: Fix unsupported eapi continuing with remaining |
| 6 |
> checks. bug 581600 |
| 7 |
> |
| 8 |
> Tighten up the xpkg loop and the use of the xpkg_continue bolean for invalid pkg or ebuilds. |
| 9 |
> This still allows addtional checks for some types of errors, while completely bypassing the |
| 10 |
> remaining checks for EAPI.unsupported. |
| 11 |
> |
| 12 |
> X-gentoo-bug: 581600 |
| 13 |
> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=581600 |
| 14 |
> --- |
| 15 |
> |
| 16 |
> I don't know if we should add more cases for it to abandon ship ;) and |
| 17 |
> not perform more checks on the ebuilds with some of the failures |
| 18 |
> detected in these exceptions. What wre your thoughts? |
| 19 |
|
| 20 |
It seems like can_force indicates that a very severe problem has been |
| 21 |
found, but it doesn't keep track of the specific problem that triggers |
| 22 |
the state. I think it would make sense to use the qatracker to keep |
| 23 |
track of this sort of state, with certain issues having a severity level |
| 24 |
which triggers the "can't force" state. |
| 25 |
|
| 26 |
Also, as we've discussed on irc, I think we should turn the plugin check |
| 27 |
methods into generator methods that yield a series of issues. That way, |
| 28 |
plugins will not need direct access to the qatracker, since they will |
| 29 |
simply yield issues to it (including those issues that trigger the |
| 30 |
"can't force" state). |
| 31 |
-- |
| 32 |
Thanks, |
| 33 |
Zac |
Archives