Re: [gentoo-portage-dev] [PATCH 5/7] eapply_user: make idempotent per changes to EAPI 6

[Michał Górny]

On Mon, 9 Nov 2015 13:14:02 -0800
Zac Medico <zmedico@g.o> wrote:

> On 11/09/2015 09:49 AM, Michał Górny wrote:
> > ---
> >  bin/phase-helpers.sh | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
> > index 2fea0b2..bd4e999 100644
> > --- a/bin/phase-helpers.sh
> > +++ b/bin/phase-helpers.sh
> > @@ -1070,6 +1070,10 @@ fi
> >
> >  if ___eapi_has_eapply_user; then
> >  	eapply_user() {
> > +		local tagfile=${T}/.portage_user_patches_applied
> > +		[[ -f ${tagfile} ]] && return
> > +		touch "${tagfile}"
> > +
> >  		local basedir=${PORTAGE_CONFIGROOT%/}/etc/portage/patches
> >
> >  		local d applied
> >
>
> Instead of touch, we can use >> "${tagfile}" to get equivalent results
> with pure bash. It shaves of a few cpu cycles, and we've actually had
> issues with touch breakage in the past:
>
> https://bugs.gentoo.org/show_bug.cgi?id=348640

Was thinking about it but assumed 'touch' would be easier to
understand. If it has caused trouble in the past, I'm all for using
pure bash instead.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>