Re: [gentoo-portage-dev] [PATCH v4] Colorize packages in user sets (bug 577720)

[Zac Medico]

On 04/19/2016 06:40 PM, Adam Mills wrote:
> Three new settings were added to /etc/portage/color.map:
> PKG_MERGE_USER_SET, PKG_BINARY_MERGE_USER_SET, and
> PKG_NOMERGE_USER_SET. These colors are applied when the package is
> selected from a set in /etc/portage/sets/
>
> X-Gentoo-bug: 577720
> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=577720
> ---
>
> [PATCH v4] Created one InternalPackageSet for each root
> [PATCH v3] Updates based on feedback from IRC meeting
> [PATCH v2] Simplification of check_sets ref Alexander Berntsen's feedback_

Thanks, it looks really nice now.

> +		# Create a single merged user set for each root
> +		self.user_sets = {}
> +		for root_name, root in self.roots.items():
> +			self.user_sets[root_name] = InternalPackageSet(initial_atoms= \
> +				chain.from_iterable(pkgset.getAtoms() \
> +				for pkgset_name, pkgset in root.sets.items() \
> +				if pkgset.user_set))
> +

Since the pkgset_name variable is unused, we could do it like this:

    for pkgset in root.sets.values()


-- 
Thanks,
Zac