| 1 |
On 02/17/2015 11:56 AM, Brian Dolbec wrote: |
| 2 |
> On Tue, 17 Feb 2015 11:26:27 -0800 |
| 3 |
> Zac Medico <zmedico@g.o> wrote: |
| 4 |
> |
| 5 |
>> On 02/17/2015 10:42 AM, Brian Dolbec wrote: |
| 6 |
>>> |
| 7 |
>>> overall, there is no way I know the code well enough to know if you |
| 8 |
>>> screwed up. But the code looks decent, so... |
| 9 |
>>> |
| 10 |
>>> My only questions are: |
| 11 |
>>> |
| 12 |
>>> pym/portage/dbapi/bintree.py: |
| 13 |
>>> |
| 14 |
>>> You removed several functions from the binarytree class and |
| 15 |
>>> essentially reduced prevent_collision to a warning message. Can |
| 16 |
>>> you briefly say why they are not needed please. |
| 17 |
>> |
| 18 |
>> Okay, I'll include this info in an updated patch: |
| 19 |
>> |
| 20 |
> |
| 21 |
> Actually, I think this one patch could be split into a few logical |
| 22 |
> ones. Tag them |
| 23 |
> |
| 24 |
> binpkg-multi-instance 1 of... |
| 25 |
> |
| 26 |
> in the commit message so it is clear they |
| 27 |
> belong together. That way the commit messages can more clearly be |
| 28 |
> relevant to the file(s) changed. |
| 29 |
> |
| 30 |
> The commit message is already a short story in length ;) before adding |
| 31 |
> these new explanations. |
| 32 |
|
| 33 |
Okay, will do. |
| 34 |
-- |
| 35 |
Thanks, |
| 36 |
Zac |
Archives