Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.
Date: Sun, 30 Mar 2014 08:17:04
Message-Id: 20140330011639.53b120d8.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes. by "Michał Górny"
1 On Sun, 30 Mar 2014 09:56:11 +0200
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Dnia 2014-03-30, o godz. 00:03:02
5 > Alexander Berntsen <bernalex@g.o> napisał(a):
6 >
7 > > -----BEGIN PGP SIGNED MESSAGE-----
8 > > Hash: SHA256
9 > >
10 > > Please use a max 50 char commit message headline, without the
11 > > period.
12 > >
13 > > On 29/03/14 19:45, Michał Górny wrote:
14 > > > +import locale +import math
15 > > Why not explicitly import what you are going to use? (On the form of
16 > > "from foo import bar, baz".)
17 >
18 > I feel like one of the points in using Python is to explicitly name
19 > functions (and modules) which you use, rather than importing
20 > everything in a single namespace and having people scroll up and down
21 > to see where functions come from.
22 >
23
24 Yes, I agree for this, it is only used once and is clearer in this
25 instance. It might be different if was used many times in the same
26 file.
27
28 --
29 Brian Dolbec <dolsen>

Attachments

File name MIME type
signature.asc application/pgp-signature