Re: [gentoo-portage-dev] Re: [PATCH] RsyncSync: don't pass None sync-rsync-extra-opts value into shlex_split

[Brian Dolbec]

On Tue, 14 Jul 2015 12:56:34 -0700
Zac Medico <zmedico@g.o> wrote:

> On Tue, Jul 14, 2015 at 12:52 PM, Zac Medico <zmedico@g.o>
> wrote:
> > This fixes an issue with SyncLocalTestCase hanging on my system.
> > ---
> >  pym/portage/sync/modules/rsync/rsync.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pym/portage/sync/modules/rsync/rsync.py
> > b/pym/portage/sync/modules/rsync/rsync.py index 8041f07..f08bf5c
> > 100644 --- a/pym/portage/sync/modules/rsync/rsync.py
> > +++ b/pym/portage/sync/modules/rsync/rsync.py
> > @@ -73,7 +73,7 @@ class RsyncSync(NewBase):
> >                 self.rsync_opts = self._rsync_opts_extend(opts,
> > rsync_opts)
> >
> >                 self.extra_rsync_opts = list()
> > -               if 'sync-rsync-extra-opts' in
> > self.repo.module_specific_options:
> > +               if
> > self.repo.module_specific_options.get('sync-rsync-extra-opts'):
> > self.extra_rsync_opts.extend(portage.util.shlex_split( self.repo.module_specific_options['sync-rsync-extra-opts']))
> >
> > --
> > 2.3.6
> >
>
> I'm not sure if this is really the correct fix. Is there supposed to
> be a None 'sync-rsync-extra-opts' value in module_specific_options?
>

I don't think so, that may have been my fault when I sent Etiene my
partial rework on his patches.

-- 
Brian Dolbec <dolsen>