Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Re: [PATCH] TestFakedbapi: override EPREFIX for bug #492932
Date: Sun, 18 Jan 2015 16:54:46
Message-Id: 20150118085424.386260c3.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] Re: [PATCH] TestFakedbapi: override EPREFIX for bug #492932 by Zac Medico
1 On Sat, 17 Jan 2015 11:16:10 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 12/20/2014 01:11 PM, Zac Medico wrote:
5 > > For tests, override portage.const.EPREFIX in order to avoid unwanted
6 > > access to /etc/portage. This override may seem evil, but it is a
7 > > convenient way to simulate a prefix install, and it is reasonable
8 > > to do this because tests should be self-contained such that the
9 > > "real" value of portage.const.EPREFIX is entirely irrelevant.
10 >
11 > Any feedback on this? I think it's good to merge.
12 >
13 > I know it's ugly, but it's simple and it works. Maybe we'll come up
14 > with something fancier later on.
15
16 I didn't think it was "ugly", 2 lines of code and some comments...
17
18 yes, merge please
19
20 --
21 Brian Dolbec <dolsen>