Re: [gentoo-portage-dev] [PATCH 3/4] EAPI 6: Enforce posixish LC_CTYPE

[Zac Medico]

On 11/15/2015 01:17 PM, Michał Górny wrote:
														
> -def check_locale():
> +def check_locale(silent=False, env=None):

We should memoize the result of this function, using the cache_key
pattern used by many of the functions in portage.dep module.

For example:

_check_locale_cache = {}

def check_locale(silent=False, env=None):
    if env is None:
        cache_key = None
    else:
        cache_key = frozenset((k, env.get(k)) for k in
            locale_categories + ('LC_ALL',))
    try:
        return _check_locale_cache[cache_key]
    except KeyError:
        pass
    ...

-- 
Thanks,
Zac