Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Cc: | "Michał Górny" <mgorny@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH 2/2] Use a single grep call for gcc warning checks | ||
| Date: | Sun, 14 Sep 2014 16:56:30 | ||
| Message-Id: | 5415C8B6.7070005@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH 2/2] Use a single grep call for gcc warning checks by "Michał Górny" |
||
| 1 | On 09/12/2014 08:47 AM, Michał Górny wrote: |
| 2 | > Use a single grep call with all gcc warning checks combined rather than |
| 3 | > calling grep separately for each message being checked. Aside to being |
| 4 | > faster, this also avoids outputting warnings in separate blocks. |
| 5 | > --- |
| 6 | > bin/install-qa-check.d/90gcc-warnings | 62 +++++++++++++++++++---------------- |
| 7 | > 1 file changed, 33 insertions(+), 29 deletions(-) |
| 8 | |
| 9 | LGTM. |
| 10 | -- |
| 11 | Thanks, |
| 12 | Zac |