Re: [gentoo-portage-dev] [PATCH] actions.py: fix missing localization import (bug 541302)

[Brian Dolbec]

On Tue, 24 Feb 2015 22:32:05 -0800
Zac Medico <zmedico@g.o> wrote:

> Since commit 206efe5f6341bce99a5e9994a0458c304513b2c3,
> FEATURES=buildpkg triggers a NameError due to a missing localization
> import. Fix the NameError, and also allow read-only PKGDIR if the
> --usepkgonly option is enabled.
>
> Fixes: 206efe5f6341 ("emerge: check for writable PKGDIR (490732)")
> X-Gentoo-Bug: 541302
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=541302
> ---
>  pym/_emerge/actions.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
> index fa4fe19..b667537 100644
> --- a/pym/_emerge/actions.py
> +++ b/pym/_emerge/actions.py
> @@ -63,6 +63,7 @@ from portage.util._async.SchedulerInterface import
> SchedulerInterface from portage.util._eventloop.global_event_loop
> import global_event_loop from portage._global_updates import
> _global_updates from portage.sync.old_tree_timestamp import
> old_tree_timestamp_warn +from portage.localization import _
>  from portage.metadata import action_metadata
>
>  from _emerge.clear_caches import clear_caches
> @@ -433,7 +434,8 @@ def action_build(settings, trees, mtimedb,
>  			_opts_no_self_update.intersection(myopts)
>
>  		need_write_bindb = not any(x in myopts for x in
> -			("--fetchonly", "--fetch-all-uri",
> "--pretend")) and \
> +			("--fetchonly", "--fetch-all-uri",
> +			"--pretend", "--usepkgonly")) and \
>  			(any("buildpkg" in
> trees[eroot]["root_config"]. settings.features for eroot in trees) or
>  			any("buildsyspkg" in
> trees[eroot]["root_config"].

LGTM

-- 
Brian Dolbec <dolsen>