Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH] gnome2-utils postinst: Restrict file types to fix false positives
Date: Tue, 29 Aug 2017 08:20:55
Message-Id: 20170829082040.20642-1-mgorny@gentoo.org
1 Restrict the file types checked by the gtk-icon-cache-update check
2 to match the one used inside the tool. This ensures that we do not
3 report any false positives for files that are intentionally skipped.
4
5 Bug: https://bugs.gentoo.org/629148
6 ---
7 bin/postinst-qa-check.d/50gnome2-utils | 7 ++++++-
8 1 file changed, 6 insertions(+), 1 deletion(-)
9
10 diff --git a/bin/postinst-qa-check.d/50gnome2-utils b/bin/postinst-qa-check.d/50gnome2-utils
11 index d0cbb4037..84025ab83 100644
12 --- a/bin/postinst-qa-check.d/50gnome2-utils
13 +++ b/bin/postinst-qa-check.d/50gnome2-utils
14 @@ -6,7 +6,12 @@ gnome2_icon_cache_check() {
15 # gnome2_icon_cache_update updates only themes with an index
16 [[ -f ${d}/index.theme ]] || continue
17
18 - find_args=()
19 + find_args=(
20 + # gtk-update-icon-cache supports only specific file
21 + # suffixes; match that to avoid false positives
22 + '(' -name '*.png' -o -name '*.svg'
23 + -o -name '*.xpm' -o -name '*.icon' ')'
24 + )
25 # if the cache does not exist at all, we complain for any file
26 # otherwise, we look for files newer than the cache
27 [[ -f ${d}/icon-theme.cache ]] &&
28 --
29 2.14.1

Replies