| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 13/11/14 02:22, Zac Medico wrote: |
| 5 |
> +if "case-insensitive-fs" in portage.settings.features: |
| 6 |
> + FIND_EXTANT_CONFIGS = \ |
| 7 |
> + FIND_EXTANT_CONFIGS.replace("-name '._cfg", "-iname '._cfg") |
| 8 |
> + |
| 9 |
Splitting inside the replace will look nicer following PEP indentation |
| 10 |
(as you won't need the '\'). |
| 11 |
|
| 12 |
> +Use case\-insensitive file name comparisions when merging and unmerging |
| 13 |
> +files. |
| 14 |
> +.TP |
| 15 |
Maybe mention a) that most people can ignore this option, and b) who |
| 16 |
it's actually for. Kind of in the kernel option help style. |
| 17 |
|
| 18 |
|
| 19 |
In general I don't like this patch. It handles a bunch of cases separately by doing lower(), when I think instead it should be handled implicitly. The data should be in a structure such that it knows whether it is supposed to be upper or lowercase, and whatever's dealing with it should deal with it accordingly, rather than checking "is this case insensitive? OK lowercase it before sending it wherever". |
| 20 |
|
| 21 |
But if you think this is the best way, I'm not going to stand in the way of this patch. |
| 22 |
- -- |
| 23 |
Alexander |
| 24 |
bernalex@g.o |
| 25 |
https://secure.plaimi.net/~alexander |
| 26 |
-----BEGIN PGP SIGNATURE----- |
| 27 |
Version: GnuPG v2 |
| 28 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 29 |
|
| 30 |
iF4EAREIAAYFAlRkiB0ACgkQRtClrXBQc7UudAD/V1r4AR5zA54Xz+LHBVNt0bnn |
| 31 |
uQ9w+146L8WYK6pDN9gBAJxZbQREeOwxKSDjluZ1lq9XARf1rh/Eqzl58wIc8I4K |
| 32 |
=c1Em |
| 33 |
-----END PGP SIGNATURE----- |
Archives