| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 01/11/2014 12:09 AM, Brian Dolbec wrote: |
| 5 |
> On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote: |
| 6 |
>> Hi all, Attached is a patch to test if Portage is going to write |
| 7 |
>> to a read-only filesystem and print out the list of filesystems |
| 8 |
>> that need to be remounted RW. This leaves ${D} intact rather than |
| 9 |
>> having some files moved before hitting the RO filesystem. Fixes |
| 10 |
>> bug 378869. Since git.overlays.gentoo.org is down, I haven't had |
| 11 |
>> the chance to rebase this against latest, but I can resubmit if |
| 12 |
>> it doesn't cleanly apply. This is my first patch to the list, so |
| 13 |
>> I apologize if I didn't submit correctly. |
| 14 |
>> |
| 15 |
>> Chris Reffett |
| 16 |
> |
| 17 |
> |
| 18 |
> yeah, patch looks good. |
| 19 |
> |
| 20 |
> Only thing I didn't like is the return 1 IS that suppose to be |
| 21 |
> True or sys.exit() value? |
| 22 |
> |
| 23 |
> If that is what the module was using, then it's ok. Personally I'm |
| 24 |
> not a fan of using 0, 1 for False, True. |
| 25 |
> |
| 26 |
> But that will come later... |
| 27 |
> |
| 28 |
That was just following the style of the rest of the module, for |
| 29 |
example a collision will return 1. This can be added to the "stuff to |
| 30 |
be fixed up in future patches" list. |
| 31 |
|
| 32 |
Chris Reffett |
| 33 |
-----BEGIN PGP SIGNATURE----- |
| 34 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 35 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 36 |
|
| 37 |
iKUEARECAGYFAlLRU7VfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl |
| 38 |
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC |
| 39 |
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1QLjQCfSJSpacHoI/IQPS/o+NFJvP6q |
| 40 |
d8YAmP+RmhoWwa3J1eRNk0BAxX1TtDg= |
| 41 |
=a7If |
| 42 |
-----END PGP SIGNATURE----- |
Archives