Re: [gentoo-portage-dev] [PATCH 2/2] repoman: move Signed-off-by to the end of the footer

[Zac Medico]

On 09/30/2018 09:27 AM, Mike Gilbert wrote:
> This makes for a cleaner looking message when multiple people add their
> SOB during a review process.
>
> Signed-off-by: Mike Gilbert <floppym@g.o>
> ---
>  repoman/lib/repoman/actions.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/repoman/lib/repoman/actions.py b/repoman/lib/repoman/actions.py
> index 3cf6f7081..4980f11eb 100644
> --- a/repoman/lib/repoman/actions.py
> +++ b/repoman/lib/repoman/actions.py
> @@ -441,9 +441,6 @@ the whole commit message to abort.
>  					bug = urlunsplit(('https',) + purl[1:])
>  			commit_footer += "\n%s: %s" % (tag, bug)
>
> -		if dco_sob:
> -			commit_footer += "\nSigned-off-by: %s" % (dco_sob, )
> -
>  		# Use new footer only for git (see bug #438364).
>  		if self.vcs_settings.vcs in ["git"]:
>  			commit_footer += "\nPackage-Manager: Portage-%s, Repoman-%s" % (
> @@ -468,6 +465,10 @@ the whole commit message to abort.
>  			else:
>  				commit_footer += ", unsigned Manifest commit"
>  			commit_footer += ")"
> +
> +		if dco_sob:
> +			commit_footer += "\nSigned-off-by: %s" % (dco_sob, )
> +
>  		return commit_footer
>
>
>

Both patches look good. Please merge.
-- 
Thanks,
Zac