| 1 |
On 12/22/2014 10:34 AM, Zac Medico wrote: |
| 2 |
> On 12/22/2014 04:59 AM, Alexander Berntsen wrote: |
| 3 |
>> The idea presented in the commit message header is very good. The |
| 4 |
>> implementation discussed in the commit message body sounds a bit |
| 5 |
>> messy, but I can't immediately think of another way to support this. |
| 6 |
> |
| 7 |
> Given existing state of the code, I think my implementation is quite |
| 8 |
> reasonable. It's seems a bit messy because the functions/methods |
| 9 |
> involved need to deal with 3 different kinds of profile nodes: |
| 10 |
> |
| 11 |
> 1) Regular profile nodes |
| 12 |
> |
| 13 |
> 2) User profile override directory in /etc/portage/profile |
| 14 |
> |
| 15 |
> 3) The root "profiles" directory, which is not really a profile node, |
| 16 |
> but is used for repository-level configurations (package.mask being the |
| 17 |
> most common example used by Gentoo) |
| 18 |
> |
| 19 |
> I will add a note about this to the commit message, since it's not |
| 20 |
> completely obvious unless you have had to dive into this code for some |
| 21 |
> reason. |
| 22 |
|
| 23 |
The updated commit message is here: |
| 24 |
|
| 25 |
https://github.com/zmedico/portage/commit/582965f8e8f0071d50abe2e9510abe6659e10242 |
| 26 |
|
| 27 |
-- |
| 28 |
Thanks, |
| 29 |
Zac |
Archives